Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

[Neil Puttock]

2008/6/21 Han-Wen Nienhuys <address@hidden>:
> On Wed, Jun 18, 2008 at 10:26 PM, Neil Puttock <address@hidden> wrote:

>> I've tried reading the force-accidental property from the music event,
>> then adding it to the trill-span-event list, but it causes a segfault.
>> :(
>
> That's strange; can you show the code for that? As far as I can see,
> you should be extracting force-accidental from the secondary-note and
> set that property in the place where you set the trill-pitch property.
> Then the property reaches the engraver in the same way that the
> trill-pitch does.

Here's the code from music-functions-init.ly with my changes:

(trill-pitch
         (if (pair? sec-note-events)
             (ly:music-property (car sec-note-events) 'pitch)
             ))
        (forced
         (if (pair? sec-note-events)
             (ly:music-property (car sec-note-events) 'force-accidental))))


     (if (ly:pitch? trill-pitch)
         (for-each (lambda (m) (ly:music-set-property! m 'pitch trill-pitch))
                   trill-events)
         (begin
           (ly:warning (_ "Second argument of \\pitchedTrill should be single 
note: "))
           (display sec-note-events)))

     (if (eq? forced #t)
         (for-each (lambda (m) (ly:music-set-property! m 'force-accidental 
forced))
                   trill-events))

     main-note))

Here's the debug info from GDB:

Program received signal SIGSEGV, Segmentation fault.
Grob::internal_set_value_on_alist (this=0x0, alist=0x60,
sym=0x7f678cc35600, v=0x104) at grob-property.cc:296
296       return scm_is_pair (immutable_property_alist_);

Regards,
Neil