[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHES] Re: Harp Pedals?
From: |
Reinhold Kainhofer |
Subject: |
Re: [PATCHES] Re: Harp Pedals? |
Date: |
Tue, 19 Aug 2008 19:19:22 +0200 |
User-agent: |
KMail/1.9.9 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Dienstag, 19. August 2008 schrieb Carl D. Sorensen:
> On 8/18/08 4:19 PM, "Reinhold Kainhofer" <address@hidden> wrote:
> > Am Montag, 18. August 2008 schrieb Valentin Villenave:
> >> I've noticed you "tagged" this new markup command as "music"; although
> >> I'm fine with it, I wonder if there would be a proper way to regroup
> >> all fret-diagrams and harp-pedal-diagrams in a same category of the
> >> docs (that could be named, I don't know, "Specific diagram
> >> notations"?)
> >
> > I was wondering about this, too, but I didn't want to touch fret diagram
> > code, too.
> >
> > How about "Instrument-specific notation", using "instrument"as category?
>
> I like "instrument" as the category.
>
> I'm not sure I like "Instrument-specific notation", as notation is too
> large, at least as I think about the anticipated uses of these markups.
Hmm, looking at the code, it seems that this is not possible:
document-markup.scm simply takes the category given in the
define-internal-markup-function, replaces all "-" by spaces[1] and
capitalizes it. So we can either use "instrument" as category and
get "Instrument" as the section title in the NR appendix, or
use "instrument-specific-markup" as category and get "Instrument Specific
Markup" (as I said, all - will be replaces by spaces automatically... no "-"
possible in the section name :( ). BTW, I like "instrument-specific-markup"
better than "instrument-specific-markups".
[1] Actually, so far it replaced only the first appearance of "-" by a space,
but left the others intact. Since the only category with a "-" was
fret-board, we didn't see any problem. However, "instrument-specific-markup"
was converted into "Instrument Specific-markup", which is just awful. A
global replace solves this.
Am Dienstag, 19. August 2008 schrieb Carl D. Sorensen:
> On 8/18/08 7:36 PM, "Han-Wen Nienhuys" <address@hidden> wrote:
> > On Mon, Aug 18, 2008 at 7:47 PM, Carl D. Sorensen <address@hidden>
wrote:
> >> Perhaps we should define a new interface --
> >> instrument-specific-markup-interface. It would contain
> >> fret-diagram-details, harp-pedal-details, clarinet-diagram-details (once
> >> the woodwind diagrams get added, etc. Then the TextScript could have
> >> instrument-specific-markup-interface added as part of the meta
> >> structure.
> >
> > Sounds good to me.
>
> OK. Reinhold, do you want to do it since you're making all the harp-pedal
> changes?
>
> We need an instrument-specific-markup-interface in
> scm/define-grob-interfaces.scm.
>
> Then we need to modify scm/define-grobs.scm so that
> instrument-specific-markup is added to the interfaces for TextScript.
Done. I've now commited all my changes to master:
- -) make-line-stencil markup function
- -) harp pedals implementation and test cases
- -) instrument-specific-markup-interface in the grob definitions
- -) change of markup type (for the docs) for fret-boards and harp diagrams
Cheers,
Reinhold
- --
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
* Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
* K Desktop Environment, http://www.kde.org, KOrganizer maintainer
* Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iD8DBQFIqwCdTqjEwhXvPN0RAkrdAKCgr7MUMYuBw3Mydw8s7Ee7VQchEQCfV8EN
LV7vZCZdBmEKs4LQJ/wL8AM=
=9zAJ
-----END PGP SIGNATURE-----
- Re: [PATCH] Re: Harp Pedals?, (continued)
- Re: [PATCH] Re: Harp Pedals?, Han-Wen Nienhuys, 2008/08/17
- [PATCHES] Re: Harp Pedals?, Reinhold Kainhofer, 2008/08/18
- Re: [PATCHES] Re: Harp Pedals?, Reinhold Kainhofer, 2008/08/18
- Re: [PATCHES] Re: Harp Pedals?, Valentin Villenave, 2008/08/18
- Re: [PATCHES] Re: Harp Pedals?, Carl D. Sorensen, 2008/08/18
- Re: [PATCHES] Re: Harp Pedals?, Reinhold Kainhofer, 2008/08/18
- Re: [PATCHES] Re: Harp Pedals?, Carl D. Sorensen, 2008/08/18
- Re: [PATCHES] Re: Harp Pedals?, Carl D. Sorensen, 2008/08/18
- Re: [PATCHES] Re: Harp Pedals?, Han-Wen Nienhuys, 2008/08/18
- Re: [PATCHES] Re: Harp Pedals?, Carl D. Sorensen, 2008/08/19
- Re: [PATCHES] Re: Harp Pedals?,
Reinhold Kainhofer <=
- Re: [PATCHES] Re: Harp Pedals?, Carl D. Sorensen, 2008/08/19
- Re: [PATCHES] Re: Harp Pedals?, Valentin Villenave, 2008/08/19
- Re: [PATCHES] Re: Harp Pedals?, Reinhold Kainhofer, 2008/08/19
- Re: [PATCHES] Re: Harp Pedals?, Valentin Villenave, 2008/08/28
- Re: [PATCHES] Re: Harp Pedals?, Reinhold Kainhofer, 2008/08/28
- Re: [PATCHES] Re: Harp Pedals?, Carl D. Sorensen, 2008/08/28
- Re: [PATCHES] Re: Harp Pedals?, Trevor Daniels, 2008/08/29
- Re: [PATCHES] Re: Harp Pedals?, Carl D. Sorensen, 2008/08/29
- Re: [PATCHES] Re: Harp Pedals?, Francisco Vila, 2008/08/29
- Re: [PATCHES] Re: Harp Pedals?, Carl D. Sorensen, 2008/08/29