lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] part combiner flexibility


From: Dan Eble
Subject: Re: [PATCH] part combiner flexibility
Date: Sun, 7 Sep 2008 18:13:46 -0400

If we go through with this (which I doubt), the handles_ should be a vector<> so we get bounds checking.

No argument there, but I don't understand what you mean by "which I doubt".

1. why is this a music property?  Since it is all about contexts, I
think a context property would be better, at least from an abstract
perspective.  It may make initialization more tricky for the user.

That was the path with the shallowest learning curve. I have changed it to use the context property partCombineContextIDs (an list of (symbol . string)), and it is much better.

Should I also make partCombineChordRange a context property?

Thanks,
--
Dan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]