[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] part combiner flexibility
From: |
Han-Wen Nienhuys |
Subject: |
Re: [PATCH] part combiner flexibility |
Date: |
Mon, 8 Sep 2008 00:08:25 -0300 |
On Sun, Sep 7, 2008 at 7:13 PM, Dan Eble <address@hidden> wrote:
>> If we go through with this (which I doubt), the handles_ should be a
>> vector<> so we get bounds checking.
>
> No argument there, but I don't understand what you mean by "which I doubt".
I doubt that we should have any sort of hard coded sequence of
different contexts to send music information to.
>> 1. why is this a music property? Since it is all about contexts, I
>> think a context property would be better, at least from an abstract
>> perspective. It may make initialization more tricky for the user.
>
> That was the path with the shallowest learning curve. I have changed it to
> use the context property partCombineContextIDs (an list of (symbol .
> string)), and it is much better.
cool.
> Should I also make partCombineChordRange a context property?
Yes, if possible.
Please send the patch again so we can inspect it.
thanks!
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen