[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Code review tool? (and [PATCH] fix for stencil rotating)
From: |
Reinhold Kainhofer |
Subject: |
Re: Code review tool? (and [PATCH] fix for stencil rotating) |
Date: |
Wed, 10 Sep 2008 11:48:35 +0200 |
User-agent: |
KMail/1.9.10 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Dienstag, 9. September 2008 schrieb Han-Wen Nienhuys:
> What do you think of using codereview.appspot for code reviews?
While I like the idea of using something like that, I find google's service
too limited and too svn-centric. In particular, it works on a file-basis
rather than on patch sets.
It also automatically includes all changes and does not let you select which
changes you want to submit. If you work on a basic issue and something else
that is based on it, you can't upload e.g. a patch that you committed locally
separately already from some uncommited changes. Also, if you committed
something locally, git-cl will completely ignore this and ask you again for a
summary (and doesn't ask for a description).
Another issue is that it relies on your gmail.com Address (I suppose using it
as the sender's address for the CCs), so mails to lilypond-devel will not
automatically go throught, because these addresses are not subscribed (unless
your are already using gmail like hanwen).
If that tool were tailored to git, it would take one local commit (identified
by the hash) and upload it as a git patch, taking the summary/description
from the patch. Patches, which are dependent on each other would then also be
no problem.
Anyway, I also did a test run for my fix to stencil rotation:
http://codereview.appspot.com/5060
Please ignore the file flags-in-scheme.ly, which just contains some debug code
to check whether the bounding boxes are now rotated correctly. I never meant
to submit it (and I also didn't add it to my local git commit, but git-cl
does not look at git commits and does not let you select files/changes
individually, but can only upload all local changes).
Both patch sets are identical up to a small change in flags-in-scheme.ly,
which should be ignored anyway.
Cheers,
Reinhold
- --
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
* Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
* K Desktop Environment, http://www.kde.org, KOrganizer maintainer
* Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFIx5fzTqjEwhXvPN0RAlNkAJ9yD11lUrgSNCh8Q2pI+364YQuKawCfYFJ2
cHL9d7Zli9XKHfdzFn4QSDQ=
=JzRT
-----END PGP SIGNATURE-----
- Code review tool?, Han-Wen Nienhuys, 2008/09/09
- Re: Code review tool? (and [PATCH] fix for stencil rotating),
Reinhold Kainhofer <=
- Re: Code review tool? (and [PATCH] fix for stencil rotating), Han-Wen Nienhuys, 2008/09/10
- Re: Code review tool? (and [PATCH] fix for stencil rotating), Reinhold Kainhofer, 2008/09/10
- Re: Code review tool? (and [PATCH] fix for stencil rotating), Carl D. Sorensen, 2008/09/10
- Re: Code review tool? (and [PATCH] fix for stencil rotating), Reinhold Kainhofer, 2008/09/11
- Re: Code review tool? (and [PATCH] fix for stencil rotating), Patrick McCarty, 2008/09/11
- Re: Code review tool? (and [PATCH] fix for stencil rotating), Reinhold Kainhofer, 2008/09/11
- Message not available
- Re: Code review tool? (and [PATCH] fix for stencil rotating), Reinhold Kainhofer, 2008/09/11
- Message not available
- Re: Code review tool? (and [PATCH] fix for stencil rotating), Reinhold Kainhofer, 2008/09/12