lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix ly:stencil-rotate; add function to rotate about absolute coordi


From: hanwenn
Subject: Re: Fix ly:stencil-rotate; add function to rotate about absolute coordinate
Date: Wed, 10 Sep 2008 07:38:56 -0700

Looks good to me.


http://codereview.appspot.com/5060/diff/201/204
File lily/stencil-scheme.cc (right):

http://codereview.appspot.com/5060/diff/201/204#newcode309
Line 309: LY_DEFINE (ly_stencil_rotate_absolute_coordinates,
"ly:stencil-rotate-absolute-coordinates",
in the interest of brevity, you could drop 'coordinates' from the name.

http://codereview.appspot.com/5060/diff/201/205
File lily/stencil.cc (right):

http://codereview.appspot.com/5060/diff/201/205#newcode98
Line 98: expr_, SCM_UNDEFINED);
in effect, this copies the underlying expression.  It might be a little
bit nicer to mirror this in the api, ie. make a

  Stencil::rotated()

and have Stencil::rotate be an abbrev of

  *this = rotated()

http://codereview.appspot.com/5060/diff/201/205#newcode127
Line 127: //   const Offset cen = Offset (extent (X_AXIS).center (),
extent (Y_AXIS).center ());
can you remove debug code?

http://codereview.appspot.com/5060/diff/201/205#newcode128
Line 128: const Real x = extent (X_AXIS).linear_combination
(relative_off[X_AXIS]);
probably not worth the effort, but you could loop through the axes here.

http://codereview.appspot.com/5060




reply via email to

[Prev in Thread] Current Thread [Next in Thread]