[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: * Fix DynamicTextSpanner left alignment.
|
From: |
Neil Puttock |
|
Subject: |
Re: * Fix DynamicTextSpanner left alignment. |
|
Date: |
Sat, 29 Nov 2008 15:54:40 +0000 |
2008/11/29 Joe Neeman <address@hidden>:
> On Sat, 2008-11-29 at 15:25 +0000, address@hidden wrote:
>> http://codereview.appspot.com/7763
>
> Hey, what happened to my comment? Anyway, it was related to the fact
> that the engraver is not the best place for layout logic (for example,
> what if 'bound-details is a callback? Then the engraver might be too
> early for it to be evaluated).
You're right, it's not ideal, but then the engraver already changes
'bound-details to deal with a dynamic script/spanner combination, and
'bound-details isn't currently a callback.
> Better to manipulate the padding in line-spanner.
OK, I'll have a rethink.
Cheers,
Neil