[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHES] Single thick barline; order of alterations in Staff.keySig
From: |
Werner LEMBERG |
Subject: |
Re: [PATCHES] Single thick barline; order of alterations in Staff.keySignature |
Date: |
Tue, 23 Dec 2008 13:59:21 +0100 (CET) |
> Please review the following two patches:
>
> 1) About the single thick barlines and the current \bar "." style
> (which produces a single centered dot). Unless someone has a good
> reason, I propose to use \bar "." for a thick bar line instead and
> drop the single centered dot altogether (or shall we add a \bar
> "dot" style?). Patch is here:
>
> http://codereview.appspot.com/11044
>
>
> 2) The Staff.keySignature alist contains the alterations of the
> current key signature in reversed order, so manually setting it of
> non-standard key signatures is a bit confusing (you have to give the
> reverse order). This patch makes Lilypond store the alterations in
> their real order:
>
> http://codereview.appspot.com/8686
I support both, and the code looks fine too (however, I'm no expert
here).
Werner