[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Enabling item-interface
From: |
Joe Neeman |
Subject: |
Re: Enabling item-interface |
Date: |
Mon, 02 Mar 2009 22:37:21 -0800 |
On Mon, 2009-03-02 at 21:05 -0700, Carl D. Sorensen wrote:
> I'm working to enable the chordChanges property for a FretBoards object.
>
> I've changed the fretboard-engraver to keep track of the last fretboard,
> using the chord-name-engraver as a model. I've verified that the code works
> to keep track of the changes in the fretboards.
>
> Here's the relevant code from fretboard-engraver.
>
> SCM changes = get_property("chordChanges");
> if (to_boolean (changes) && scm_is_pair(last_fret_notes_)
> && ly_is_equal (last_fret_notes_, fret_notes))
> fret_board_->set_property ("begin-of-line-visible", SCM_BOOL_T);
Why does ChordName use 'begin-of-line-visible = #t instead of
'break-visibility = begin-of-line-visible like all the other items?
That's why this change doesn't work AFAICT: chord-name.cc has extra
logic to deal with the 'begin-of-line-visible property that doesn't
apply to FretBoard.
Joe