Re: Fix key signatures with accidentals in specific octave.

[n . puttock]

On 2009/04/17 19:25:31, joeneeman wrote:
> http://codereview.appspot.com/11052/diff/3409/2410
> File scm/music-functions.scm (right):

> http://codereview.appspot.com/11052/diff/3409/2410#newcode1047
> Line 1047: ((and (equal? ignore-octave #f)
> I think eq? is more appropriate here

Done.

> http://codereview.appspot.com/11052/diff/3409/2410#newcode1048
> Line 1048: (and
> use (and a b c) instead of (and a (and b c))

Done.

> http://codereview.appspot.com/11052/diff/3409/2410#newcode1073
> Line 1073: (if (and (not (= (sign this-alt) 0))
> Surely (= (sign x) 0) is the same as (= x 0)

Of course!

I should have thought a bit more about it rather than trying to
duplicate the C++ code exactly.

> http://codereview.appspot.com/11052/diff/3409/2410#newcode1075
> Line 1075: (< (sign (* prev-alt this-alt)) 0)))
> Surely (< (sign x) 0) is the same as (< x 0)

Yes. :)



http://codereview.appspot.com/11052