[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: crash while processing lily-7d242e8d.ly
From: |
Carl D. Sorensen |
Subject: |
Re: crash while processing lily-7d242e8d.ly |
Date: |
Fri, 1 May 2009 17:27:29 -0600 |
On 5/1/09 2:52 PM, "Neil Puttock" <address@hidden> wrote:
> 2009/5/1 Patrick McCarty <address@hidden>:
>
>> It's a judgment call, but I think you would be the best candidate for
>> fixing it, since you have recently looked at this code.
>
> Hehe. :)
>
> The less diplomatic answer:
>
> You should fix it because your patch broke ly:error.
>
> You could of course use an extra scm_is_pair to check whether REST is
> null, but I think it would be better to remove the extra code
> completely and instead extract each argument from the markup error
> message.
OK, I've looked at this some more, and now I see the problem with my fix,
and why it would be better to fix the call to ly:error in scm/markup.scm.
It will take a bit longer, but I'll fix it.
Thanks,
Carl