lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Fix crash when a stencil routine is missing


From: Patrick McCarty
Subject: Re: [PATCH v2] Fix crash when a stencil routine is missing
Date: Sun, 5 Jul 2009 20:39:25 -0700
User-agent: Mutt/1.5.18 (2008-05-17)

On Sun, Jul 05, 2009 at 08:22:02PM -0700, Graham Percival wrote:
> On Sun, Jul 05, 2009 at 06:01:21PM -0700, Patrick McCarty wrote:
> > On Sun, Jul 05, 2009 at 05:39:45PM -0700, Graham Percival wrote:
> > > 
> > > -dwarning-as-error
> > > looks fine to me.
> > 
> > Okay.  On second thought, it looks decent to me too.
> 
> Wasn't that your initial proposal?  Did I misread the patch?

I was reusing Jan's name for the option, and initially I was not sure
I liked the name.  Now I think the name looks okay (semantically).

> > > ... oh wait, here it is:
> > > #(ly:set-option 'point-and-click #f)
> > 
> > I think Han-Wen suggested to enable this option for the entire
> > regression test suite, so adding this option to every single
> > regression test would not be reasonable.
> > 
> > In other words, some makefile hacking is needed, which I would
> > probably need to delegate.
> 
> I doubt that the regtests compile without warnings, and I'm not
> certain that we have enough Frogs to eat all the issues that would
> be added if we went this route.
> 
> (I'd love to be proven wrong about this, though!)

The patch will enable warnings by default for every missing stencil,
but the new option will enable *errors*, causing the regression test
suite to fail.

Since I don't know how to enable the new option for the entire test
suite, I'm presently compiling the docs and will examine the logs for
the new warnings.

Thanks,
Patrick




reply via email to

[Prev in Thread] Current Thread [Next in Thread]