[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New markup commands: \left-brace & \right-brace.

From: n . puttock
Subject: Re: New markup commands: \left-brace & \right-brace.
Date: Thu, 16 Jul 2009 22:43:08 +0000

Reviewers: Patrick McCarty,

Thanks for the review, Patrick.

On 2009/07/16 03:40:58, Patrick McCarty wrote:
File scm/define-markup-commands.scm (right):
Line 2625: (find-brace (binary-search 0 575 get-y-from-brace
Would Open_type_font::count () return the value 575 you need here?

If it does return 575, I would recommend writing and using a callback
retrieve this value, named something like "ly:otf-glyph-count".

An excellent suggestion; I wasn't too happy with the hard-coded value,
so this will be a nice refinement.

Brace yourself for a new patch set. :)

New markup commands: \left-brace & \right-brace.

Please review this at

Affected files:
  A input/regression/
  M scm/define-markup-commands.scm
  M scm/lily-library.scm

reply via email to

[Prev in Thread] Current Thread [Next in Thread]