lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

SVG backend: Output a single SVG file for each page


From: joeneeman
Subject: SVG backend: Output a single SVG file for each page
Date: Fri, 07 Aug 2009 23:56:48 +0000

lgtm. You can ignore my nitpicking if you disagree.


http://codereview.appspot.com/105045/diff/5/1005
File scm/framework-svg.scm (right):

http://codereview.appspot.com/105045/diff/5/1005#newcode60
Line 60: (dump (ec 'svg))
Just a very very minor thing: IWBN to have eo and ec closer together.
For example, if svg-header just returned the alist of attributes then
you could write
(dump (eo (cons 'svg (svg-header paper)))
...
(dump (ec 'svg))
and it would be totally obvious that they match.

http://codereview.appspot.com/105045




reply via email to

[Prev in Thread] Current Thread [Next in Thread]