Re: Use our own ~s ly:format placeholder, since guile is broken with wide chars

[joeneeman]

On 2009/08/22 00:11:34, Reinhold wrote:
> http://codereview.appspot.com/109070/diff/1/2
> File lily/general-scheme.cc (right):

> http://codereview.appspot.com/109070/diff/1/2#newcode437
> Line 437: replace_all (&s, "\"", "\\\"");
> On 2009/08/21 22:59:33, joeneeman wrote:
> > Don't forget to escape $. Or else use single quotes rather than
double quotes.

> Good catch. $ needs to be escaped, too. Using single quotes does not
work with
> gs.

Well, it should be the shell that sees the quotes, not gs. Perhaps
you're using cmd.exe and it doesn't like single quotes? Which brings up
the issue that the escaping/quoting rules are different between windows
and linux, so you'd need to test which system lilypond is running on...

Unless you use guile's system* function instead of system, which doesn't
run a shell and hence needs no escaping or quoting. That's probably a
safer and simpler approach.

http://codereview.appspot.com/109070