lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Tracker 836: Add facility to change output file-name for a \book blo


From: Carl . D . Sorensen
Subject: Re: Tracker 836: Add facility to change output file-name for a \book block
Date: Wed, 04 Nov 2009 04:31:44 +0000

Ian,

I found some indentation errors in the .ly file.

Thanks for your patience,

Carl



http://codereview.appspot.com/143055/diff/19/1019
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/143055/diff/19/1019#newcode616
Line 616: (let* ( (get-notes (lambda (ev-chord)
eliminate space between ( (, and align the following lines

http://codereview.appspot.com/143055/diff/19/1019#newcode626
Line 626: (let*(  (trill-pitch (ly:music-property (car sec-note-events)
'pitch))
space after let*, no space before (trill-pitch

http://codereview.appspot.com/143055/diff/19/1019#newcode628
Line 628: 'force-accidental)))
This alignment isn't right.  'force-accidental should align with (car

http://codereview.appspot.com/143055/diff/19/1019#newcode630
Line 630: (if (ly:pitch? trill-pitch)
(if should align with e in let*

http://codereview.appspot.com/143055/diff/19/1019#newcode632
Line 632: (ly:music-set-property! m 'pitch trill-pitch)) trill-events)
should be indented relative to lambda

http://codereview.appspot.com/143055/diff/19/1019#newcode638
Line 638: (for-each (lambda (m)
align with (eq?

http://codereview.appspot.com/143055/diff/19/1019#newcode639
Line 639: (ly:music-set-property! m 'force-accidental forced))
align with (eq?

http://codereview.appspot.com/143055




reply via email to

[Prev in Thread] Current Thread [Next in Thread]