[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Quit [now definitely O/T]

From: Han-Wen Nienhuys
Subject: Re: Quit [now definitely O/T]
Date: Fri, 13 Nov 2009 02:08:32 -0200

Jumping into this thread randomly.

While I am known to be less welcoming-friendly at times (especially if
I am busy or stressed out), you also have to keep in mind that I have
(had) been accepting patches from a lot of people for a long time.  I
have plenty of experience with contributed patches that were
semi-finished; typically, after accepting the patch, the polishing
never happens, the contributor disappears, and at some point I was the
person that would have to clean things up.   That experience has made
me very demanding wrt to accepting code contributions, because the
unfinished ones would incur me extra work in the future.

On Thu, Nov 12, 2009 at 7:59 PM, Joe Neeman <address@hidden> wrote:
>> > As I mentioned above (and others have mentioned), the learning curve for
>> > developing is quite steep. I applaud the effort by Graham et al to
>> > improve the documentation, especially the Contributor's Guide, which has
>> > been a big help even in its incomplete form. However, a lot of the code
>> > is difficult to follow - when is stop_translation_timestep called in
>> > engravers, for instance? It took me a while to understand that it will
>> > be called even due to rhythms in other voices besides the one the
>> > engraver is interested in.
>> I didn't even know that.  I hope we can get this documented.  Would you be
>> willing to take a stab at how events are passed to engravers (or how various
>> routines inside an engraver are called from outside the engraver)?
> It would also be nice to have a summary of the order in which things
> happen for engravers. For example, when are the announced grobs
> processed and what happens if you create a grob after grobs have already
> been announced? Currently, I only have a very vague picture of how the
> whole engraving step works so you aren't alone in your confusion.

If you really want know this, we can mark an IRC/chat session or
something so I can pass this information on. It's not that
complicated, but the code also has some optimizations that may
obfuscate things.

As for the create grob after announce: this happens in a loop.  The
announce/acknowledge stops when no new grobs are created anymore - see
Engraver_group::do_announces ()

Han-Wen Nienhuys - address@hidden -

reply via email to

[Prev in Thread] Current Thread [Next in Thread]