[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] functional-or returned #f for (functional-or #f #t #f). Fixe
Re: [PATCH] functional-or returned #f for (functional-or #f #t #f). Fixed.
Sun, 22 Nov 2009 17:06:50 -0800
On Tue, Nov 17, 2009 at 11:24 PM, David Kastrup <address@hidden> wrote:
> Patrick McCarty <address@hidden> writes:
>> On 2009-11-16, David Kastrup wrote:
>>> It still suffers from not doing short-circuit evaluation. For
>>> readability and efficiency, I'd really prefer replacing
>>> '(apply functional-or' with '(any'
>> It looks like Neil removed the "is-harmonic" binding from this
>> procedure a couple of days ago, since it was unused.
>> So, nothing really needs to be changed after all. :-)
> Still I feel more comfortable with this patch in place. I am not
> entirely sure whether it would not be simpler to just scratch both
> functional-or and functional-and altogether since they are basically
> only useful in situations where one would better use a different mapping
> function with short-circuit evaluation.
Oh, I didn't realize you wanted to change the `functional-or' itself.
I don't think we should remove the two procedures entirely, because
users might have written Scheme extension code that uses them.
Can you send a formal patch so I can see how you want these procedures