[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Make define-builtin-markup{,-list}-command #:category #:properties

From: nicolas . sceaux
Subject: Re: Make define-builtin-markup{,-list}-command #:category #:properties keywords (issue160048)
Date: Thu, 03 Dec 2009 14:58:38 +0000


When defining a user markup command, it would be better not to modify at
all the variables from the (lily) module, even if you took care of the
memory leak. Also, there is one file to be deleted, and the associated
\include to be removed from an init .ly file.

File ly/ (left):
ly/ %%;; to be define later, in a closure
If this file is empty, then it shall be deleted
File scm/markup.scm (right):
scm/markup.scm:101: (set! body (cddr body)))
Why is this needed?
Could #:allow-other-keys take care of that?
scm/markup.scm:131: ;; Register the new function, for markup
I still have the feeling that user defined commands should not modify
variables from (lily) module.
Could there be e.g. a module check, so that the macro expand into the
documentation related settings only for builtin commands?
scm/markup.scm:168: (set! body (cddr body)))
Same as above.
scm/markup.scm:199: (hashq-set! markup-list-functions ,command-name #t)
Same as for define-markup-command

reply via email to

[Prev in Thread] Current Thread [Next in Thread]