lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Quoting different types of events for \cueDuring and \quoteD


From: Ian Hulin
Subject: Re: [PATCH] Quoting different types of events for \cueDuring and \quoteDuring
Date: Tue, 22 Dec 2009 17:27:43 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b1pre Thunderbird/3.0

Hi Reinhold,
On 22/12/09 15:34, Reinhold Kainhofer wrote:
Typically, \quoteDuring is used to duplicate everything in a voice,
while \cueDuring is used to only quote the notes, but not e.g.
phrasing, slurs, accents, markup, etc.

So, this patch adds an additional property quotedCueEventTypes in
addition to quotedEventTypes, which allows to quote different types
for \cueDuring than for \quoteDuring.

By default, \quoteDuring now quotes everything (i.e. StreamEvent), while
\cueDuring quotes only notes, rest, ties, beams and tuplets.

Here's the patch (also includes a regtest):
http://codereview.appspot.com/180114

Okay to apply?

Will the docs make the distinction about \quoteDuring vs. \cueDuring usage clear?
I can see there is stuff in the amended docstrings in
define-context-properties.scm which will go into the docs somewhere but do you feel that's enough for end-users?

Cheers,
(und fröhliche Weihnachten),
Ian






reply via email to

[Prev in Thread] Current Thread [Next in Thread]