[PATCH] Re: Centered Poet rolling of the paper 2.12.2 and 2.13.1

[Alexander Kobel]

Alexander Kobel wrote:
> Wilbert Berendsen wrote:
> > Hi,
> >
> > this code:
> >
> > \header {
> >   poet = \markup \center-column {
> >     \line { poet with Long Name }
> >     \small (1800-1900)
> >   }
> >   composer = \markup \center-column {
> >     \line { composer with Long Name }
> >     \small (1800-1900)
> >   }
> > }
> >
> > { c' }
> >
> > results in falling the poet off the paper. It looks like the column is 
> > centered on the margin.
>
> Confirmed.  Looks like a strange artifact of the \fill-line markup 
> (containing both poet and composer) w.r.t. a negative first X-extent 
> entry of a \center-column, IIUC.

The attached patch for fill-line (scm/define-markup-commands.scm) should 
do the expected thing.
fill-line currently only considers the extents of the stencils, not 
their position relative to the X-origin; with the patch, they are 
shifted according to the first stencil argument.

Sorry in advance for non-proper indentation, a probably non-proper patch 
format, and not having in on Rietveld or something like this, but to be 
honest, I don't want to take the time to bother with git's functionality 
and a coding account setup right now.


Cheers,
Alexander

--- scm/define-markup-commands.scm.new  2010-01-11 16:47:46.000000000 +0100
+++ scm/define-markup-commands.scm      2010-01-11 16:43:31.000000000 +0100
@@ -850,11 +850,8 @@
 
     (if (null? (remove ly:stencil-empty? orig-stencils))
        empty-stencil
-  (ly:stencil-translate-axis
-        (stack-stencils-padding-list X
-                                    RIGHT fill-space-normal line-stencils)
-     (- (car (ly:stencil-extent (car stencils) X)))
-     X))))
+       (stack-stencils-padding-list X
+                                    RIGHT fill-space-normal line-stencils))))
 
 (define-markup-command (line layout props args)
   (markup-list?)