lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Avoid orphan/widow lines (issue190102)


From: shingarov
Subject: Re: Avoid orphan/widow lines (issue190102)
Date: Thu, 21 Jan 2010 23:02:15 +0000


http://codereview.appspot.com/190102/diff/1/2
File lily/constrained-breaking.cc (right):

http://codereview.appspot.com/190102/diff/1/2#newcode529
lily/constrained-breaking.cc:529: last_markup_line_  =
to_boolean(last_scm);
On 2010/01/21 20:45:06, joeneeman wrote:
space before (

Done.

http://codereview.appspot.com/190102/diff/1/2#newcode531
lily/constrained-breaking.cc:531: first_markup_line_ =
to_boolean(first_scm);
On 2010/01/21 20:45:06, joeneeman wrote:
space before (

Done.

http://codereview.appspot.com/190102/diff/1/7
File lily/paper-book.cc (right):

http://codereview.appspot.com/190102/diff/1/7#newcode554
lily/paper-book.cc:554: {
On 2010/01/21 20:45:06, joeneeman wrote:
indentation should be
if (blah)
   {
     foo();
   }


Done.

http://codereview.appspot.com/190102/diff/1/7#newcode558
lily/paper-book.cc:558: ps->set_property
("first-markup-line", SCM_BOOL_F);
On 2010/01/21 20:45:06, joeneeman wrote:
extra spaces?

Done.

http://codereview.appspot.com/190102/show




reply via email to

[Prev in Thread] Current Thread [Next in Thread]