Re: Make tab-note-heads and fretboards use common code. (issue186268)

[Carl . D . Sorensen]

OK, so I added the optional default to ly:context-property, and fixed
the indentation.

make check works.

I think it's good to go now.



http://codereview.appspot.com/186268/diff/1/7
File scm/translation-functions.scm (right):

http://codereview.appspot.com/186268/diff/1/7#newcode236
scm/translation-functions.scm:236: "Convert @var{placement-list} to
string-fret list."
On 2010/01/24 01:36:35, Carl wrote:
> On 2010/01/23 16:42:33, Neil Puttock wrote:
> > indentation

> What is the indentation issue here?

Done.

http://codereview.appspot.com/186268/diff/1/7#newcode287
scm/translation-functions.scm:287: (ensure-number
On 2010/01/24 01:36:35, Carl wrote:
> On 2010/01/23 16:42:33, Neil Puttock wrote:
> > Default for ly:context-property instead?

> Do you mean to modify ly:context-property so that it asks for a
(probably
> optional) default, and then returns the default if the property isn't
found?


Done.

http://codereview.appspot.com/186268/show