lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Enhancement: tabalture chord repetition (issue224082)


From: Marc Hohl
Subject: Re: Enhancement: tabalture chord repetition (issue224082)
Date: Mon, 01 Mar 2010 20:24:33 +0100
User-agent: Thunderbird 2.0.0.23 (X11/20090817)

Nicolas Sceaux schrieb:
Le 1 mars 2010 à 10:00, Marc Hohl a écrit :

address@hidden schrieb:
http://codereview.appspot.com/224082/diff/1/3
File ly/chord-repetition-init.ly (right):

http://codereview.appspot.com/224082/diff/1/3#newcode51
ly/chord-repetition-init.ly:51: #(define-public (tab-repeat-chord
previous-chord location duration articulations)
It would be  better to define a generic repetition function, taking the
event types that should be kept for NoteEvents. default-repeat-chord and
tab-repeat-chord would then use this function.  I'm writing it on other
post.
Done. Thanks for this improvement!

Marc

http://codereview.appspot.com/224082/show

Shouldn't there be a few words of explantion about using q and
\tabChordRepetition somewhere in 2.4.1 "Common notation for fretted
strings"?
Done. I hope it is ok.

Marc

http://codereview.appspot.com/224082/show






reply via email to

[Prev in Thread] Current Thread [Next in Thread]