Re: compilation failure with g++ 4.5

[Graham Percival]

We saw this two weeks ago, and Jan seemed to think it was
premature:
http://lists.gnu.org/archive/html/lilypond-devel/2010-02/msg00401.html

I have no knowledge of the actual code in question, so I'm not
objecting to the commit; I just remembered the earlier discussion.

Cheers,
- Graham

On Sat, Mar 06, 2010 at 10:06:22PM +0100, Werner LEMBERG wrote:
> 
> [git commit 829d4293]
> 
> Building lilypond with g++ 4.5 fails:
> 
>   spacing-spanner.cc: In static member function 'static std::vector<Grob*> 
> Spacing_spanner::get_columns(Grob*)'
>   spacing-spanner.cc:52:35: error: expected primary-expression before '*' 
> token
>   spacing-spanner.cc:52:36: error: expected primary-expression before '>' 
> token
> 
> Note that g++ 4.5 is still experimental; however, it seems that it
> becomes more picky...
> 
> I've applied the patch below, and it seems to work.
> 
> 
>     Werner
> 
> 
> ======================================================================
> 
> 
> --- spacing-spanner.cc.old    2010-03-06 19:39:55.000000000 +0100
> +++ spacing-spanner.cc        2010-03-06 20:05:32.000000000 +0100
> @@ -49,8 +49,8 @@
>    vsize end = binary_search (all, (Grob*) me->get_bound (RIGHT),
>                            &Paper_column::less_than);  
>    
> -  all = vector<Grob*>::vector<Grob*> (all.begin () + start,
> -                                   all.begin () + end + 1);
> +  all = vector<Grob*> (all.begin () + start,
> +                    all.begin () + end + 1);
>    return all;
>  }
> 
> 
> _______________________________________________
> lilypond-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/lilypond-devel