lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Lilypond issues success/failure termination message (issue736041)


From: pnorcks
Subject: Lilypond issues success/failure termination message (issue736041)
Date: Wed, 24 Mar 2010 21:59:21 +0000

Hi Ian,

I haven't actually tested this patch, but here are a few comments.


http://codereview.appspot.com/736041/diff/1/5
File scm/lily.scm (right):

http://codereview.appspot.com/736041/diff/1/5#newcode262
scm/lily.scm:262:
I removed this 'gettext wrapper because LilyPond only supports Guile
1.8.2 or later.

Do we really want to reinstate this?

http://codereview.appspot.com/736041/diff/1/5#newcode296
scm/lily.scm:296:
These commented lines should be part of a separate patch.

http://codereview.appspot.com/736041/diff/1/5#newcode763
scm/lily.scm:763: (if (= (random 40) 1)
You need to rebase again.

http://codereview.appspot.com/736041/show




reply via email to

[Prev in Thread] Current Thread [Next in Thread]