Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes

[Richard Gay]

On Tue, 30 Mar 2010 22:53:44 +0100, Neil Puttock <address@hidden>
wrote:
> The warnings aren't spurious, since the lyrics aren't attached to the
> grace notes (the incorrect alignment gives this away): they end up
> aligned to the nearest paper column.
>
> If you have a look at get_current_note_head () in lyric-engraver.cc,
> you'll see it returns NULL if the current head is a grace note.  I
> suggest reworking it slightly to added a boolean arg include_graces so
> both the Lyric_engraver and Extender_engraver can read
> includeGraceNotes and pass the value.

Thanks for this hint. Did as you suggested and extended
get_current_note_head(). Now the not-so-spurious warnings do no
longer occur and syllables are aligned correctly (at least for
my simple test cases like the one I added to the docs). The attached
patch again applies to current git.

Since I am pretty new to lilypond, I can hardly figure out what might
be good test cases for the patch. Also, I do not know how to test the
changes to the Extender_engraver. Any hints, particularly regarding the
latter?

> Don't forget to add includeGraceNotes to the engraver documentation
> (it should go in the `read' section in the ADD_TRANSLATOR () macro at
> the bottom of both engravers).
(done)

Cheers,
Richard

includeGraceNotes-lyrics-syllables-of-grace-notes.patch
Description: Text Data