[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Fix #786. (issue885044)
From: |
n . puttock |
Subject: |
Fix #786. (issue885044) |
Date: |
Mon, 05 Apr 2010 23:59:09 +0000 |
Reviewers: ,
Message:
Hi,
This patch implements the suggestion outlined here:
http://lists.gnu.org/archive/html/lilypond-devel/2010-01/msg00120.html
Please review.
Thanks,
Neil
Description:
Fix #786.
Send a CompletizeExtenderEvent at the end of each lyrics block so that
the Extender_engraver can tie up loose ends with any pending extender.
* input/regression (display-lily-tests.ly):
add extra space to \lyricsto and \addlyrics test to account for
silenced
display method
* lily/extender-engraver.cc:
add listener for CompletizeExtenderEvent which will call
completize_extender ()
if necessary
revert previous fix which checked for empty LyricText grob
* lily/hyphen-engraver.cc:
revert fix as above
* lily/lyric-engraver.cc (process_music):
don't create empty LyricText grobs
* scm/define-event-classes.scm (event-classes):
add completize-extender-event as child of music-event
* scm/define-music-display-methods.scm:
add display method for CompletizeExtenderEvent (returns empty string)
* scm/define-music-types.scm (music-descriptions):
add CompletizeExtenderEvent
* scm/ly-syntax-constructors.scm (lyric-combine-music):
insert CompletizeExtenderEvent at the end of the sequential music
(i.e.,
following the last lyric)
Please review this at http://codereview.appspot.com/885044/show
Affected files:
M input/regression/display-lily-tests.ly
M lily/extender-engraver.cc
M lily/hyphen-engraver.cc
M lily/lyric-engraver.cc
M scm/define-event-classes.scm
M scm/define-music-display-methods.scm
M scm/define-music-types.scm
M scm/ly-syntax-constructors.scm
- Fix #786. (issue885044),
n . puttock <=