[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: Modify feta font to put noteheads in separate sub-table

From: Carl Sorensen
Subject: Re: [PATCH]: Modify feta font to put noteheads in separate sub-table
Date: Sun, 18 Apr 2010 08:22:47 -0600

On 4/17/10 10:51 PM, "Werner LEMBERG" <address@hidden> wrote:

>> This is my first time working on the font building system, so I may have
>> made some mistakes.
>> Could someone who is familiar with the font system verify that I've done
>> things right?
> This looks very nice!

Thank you for the confirmation. As far as I can see, there's no more
knowledgeable person about fonts than you in the LilyPond devel team.  So
now I can stop worrying that I did something fundamentally wrong.

> I have only two minor formatting nits:
>   . It seems that you sometimes use spaces where you should use tabs.

When should I use tabs instead of spaces?  My personal preference is to
always use spaces, because that way the indenting is consistent, regardless
of editor settings.  But if I'm supposed to use tabs, I'll be happy to
change to them.

>   . Please try to stay within 80 characters per line.

I will check again and make sure that I stay within the boundaries.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]