[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Critical issues

From: Marc Hohl
Subject: Re: Critical issues
Date: Fri, 14 May 2010 08:24:37 +0200
User-agent: Thunderbird (X11/20100317)

Joe Neeman schrieb:
On Wed, 2010-05-12 at 22:14 +0200, Karl Hammar wrote:
Issue 1080: Regression: bar lines in double bar are positioned too
close together

"pnorcks" mentions commit 27a4d9354effb09c696925881ec4df007da8a0db
as a possible cause. Reverting part of that commit:
gives me the attached grace-start result which resembles the 2.13.17 result presented in the bug tracker.

What should we do about it?

I'd suggest we check with Marc Hohl to see what the intent of that
change was. I suspect that it was an attempt to change how \bar "||" is
aligned so that it lines up better with the new segno barline.
Yes, that's right.
 If I'm
right, though, then Marc misunderstood the last parameter to
Stencil::add_at_edge, and the correct code would be
m.add_at_edge (X_AXIS, LEFT, thin, thinkern / 2);
m.add_at_edge (X_AXIS, RIGHT, thin, thinkern);
Oh, I see. Yes, I misunderstood the spacing - I asked about that subject
while working on the segno patch, but no-one told me I was wrong here
(or I have missed something important).

Sorry for this, and thanks to Karl for pointing this out and to Joe for
giving the right solution. I attached a patch which does the right thing.



From 15b2103f19fe92c03a6f423cc93ac51e97f0a113 Mon Sep 17 00:00:00 2001
From: Marc Hohl <address@hidden>
Date: Fri, 14 May 2010 08:21:03 +0200
Subject: [PATCH] Issue 1080: corrected spacing in double bar lines

 lily/ |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lily/ b/lily/
index d3f21e5..a00dc0e 100644
--- a/lily/
+++ b/lily/
@@ -200,7 +200,7 @@ Bar_line::compound_barline (Grob *me, string str, Real h,
       m.add_at_edge (X_AXIS, RIGHT, thin, thinkern);
       m.add_at_edge (X_AXIS, LEFT, thin, thinkern / 2);
-      m.add_at_edge (X_AXIS, RIGHT, thin, thinkern / 2);
+      m.add_at_edge (X_AXIS, RIGHT, thin, thinkern);
   else if (str.find ("S") != NPOS || str == "|._.|")

reply via email to

[Prev in Thread] Current Thread [Next in Thread]