lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Critical issues


From: Carl Sorensen
Subject: Re: Critical issues
Date: Fri, 14 May 2010 07:34:27 -0600



On 5/14/10 7:01 AM, "Karl Hammar" <address@hidden> wrote:

> Carl Sorensen:
>> On 5/13/10 1:11 PM, "Karl Hammar" <address@hidden> wrote:
> ...
>> make test-baseline
> ...
>> make check
> ...
> 
> Ok, done that.
> 
> With the guidance from http://code.google.com/p/lilypond/issues/detail?id=881:
> 
>   I can't explain why, but making the print function pure by redefining
> ly:tie::print
>   just for LaissezVibrerTie seems to fix this (I haven't done a regtest check,
> so it
>   might end up breaking something else):
> 
>   (define-public (laissez-vibrer::print grob)
>     (ly:tie::print grob))
> 
>   (then add laissez-vibrer::print to pure-print-callbacks)
> 
> I tried this:
> 
>   diff --git a/scm/define-grobs.scm b/scm/define-grobs.scm
>   index 176debd..35186f8 100644
>   --- a/scm/define-grobs.scm
>   +++ b/scm/define-grobs.scm
>   @@ -2345,8 +2345,12 @@
>             (interval-union '(0 . 0) (cons smaller larger)))
>           '(0 . 0))))
> 
>   +(define-public (laissez-vibrer::print grob)
>   +  (ly:tie::print grob))
>   +
>    (define pure-print-callbacks
>      (list
>   +   laissez-vibrer::print
>       fret-board::calc-stencil
>       note-head::brew-ez-stencil
>       print-circled-text-callback
> 
> $ make test-redo
> 
>> out/test-results/index.html
>> 
>> that shows the results of the regression tests.
> ...
> 
> I got (except the test-output-distance.ly) an distance of 0300030 and
> "HEAD is: 22d889f4d27469864c31db81445e9de49774ae23" to the right and
> left plus the git-diff to the rigth.
> 
> So I assume it was the wrong patch try. Does anybody have Neil's
> proposed fix available ?

You also need to redefine the 'stencil for laissez-vibrez tie in
scm/define-grobs.scm.

HTH,

Carl




reply via email to

[Prev in Thread] Current Thread [Next in Thread]