[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: Fix issue 1096

From: David Kastrup
Subject: Re: [PATCH]: Fix issue 1096
Date: Thu, 27 May 2010 16:15:10 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Carl Sorensen <address@hidden> writes:

> Benjamin Peterson prepared a patch to fix this issue.
> It's in the lexer, and I'm not at all comfortable with the lexer.  However,
> the patch has been demonstrated to work and to not break the regtests.
> Please review this patch.

I think one should try to feed erroneous strings to the includable lexer
and look at the resulting error messages.  That's probably hard to do
with a regtest (since the regtest is not supposed to produce errors),
but it would provide some sanity check with regard to the error
mechanisms tracking the right input.

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]