[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: Fix issue 1096

From: David Kastrup
Subject: Re: [PATCH]: Fix issue 1096
Date: Fri, 28 May 2010 12:04:05 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Carl Sorensen <address@hidden> writes:

> On 5/27/10 2:58 PM, "Benjamin Peterson" <address@hidden> wrote:
>> Carl Sorensen <c_sorensen <at>> writes:
>>> I saw the comment from David not as a suggestion to build an automated
>>> process for feeding the erroneous strings, but as a one-time testing
>>> suggestion.  Hence my request for help.
>> I'm not sure what the purpose would be for an error test in this case, since
>> the
>> patch is about preventing an error.
> That's what I thought as well, but I think that David was feeling that
> there was some need for more extensive testing to make sure that
> errors were properly handled instead of segfaulting.

Error messages tend to give an extract about where the interpreter
thinks he currently is in its (possibly recursive) input state.  This
information is not as readily apparent or even extracted by other means.

I have no clue about the inner workings of the parser/input.  And it
appears that those who are deciding whether to commit are in a similar

If the error reactions of the parser appear consistent with
expectations, that could provide some basic reassurance that the patch
does not work just by chance and does not mess up internal states all
too much.

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]