Re: woodwind diagrams in lilypond (http://codereview.appspot.com/1385041)

[Neil Puttock]

On 28 May 2010 07:45, Mike Solomon <address@hidden> wrote:

>    At http://codereview.appspot.com/1385041, you will find a patch that
> implements several woodwind diagrams (piccolo, flute, oboe, clarinet, bass
> clarinet, saxophone, bassoon, and contrabassoon) in Lilypond.  I would very
> much appreciate any and all comments on this new feature, specifically with
> respect to the following three questions:
>
> 1) Are the diagrams correct?

I'm only familiar with the clarinet, but the keys all seem to be in order.

> 2) Do the diagrams look nice?

They're very impressive; well done!

> 3) Is the code in the patchelegant?

Unfortunately two of the files (bezier-tools.scm and
woodwind-diagrams.scm) are only available for viewing via the
`Download' link.  Could you try re-uploading them?

I'll post some comments on Rietveld once I've had a closer look.

Cheers,
Neil