lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Fix 1112. (issue1670042)


From: n . puttock
Subject: Fix 1112. (issue1670042)
Date: Sun, 20 Jun 2010 20:12:52 +0000

LGTM.


http://codereview.appspot.com/1670042/diff/1/2
File input/regression/page-breaking-min-distance.ly (right):

http://codereview.appspot.com/1670042/diff/1/2#newcode1
input/regression/page-breaking-min-distance.ly:1: \version "2.13.22"
2.13.26

http://codereview.appspot.com/1670042/diff/1/2#newcode9
input/regression/page-breaking-min-distance.ly:9:
between-scores-system-spacing #'minimum-distance = #'20
#20

http://codereview.appspot.com/1670042/diff/1/2#newcode18
input/regression/page-breaking-min-distance.ly:18:
There's an extra newline following this row (whitespace error: new blank
line at EOF)

http://codereview.appspot.com/1670042/diff/1/3
File lily/constrained-breaking.cc (right):

http://codereview.appspot.com/1670042/diff/1/3#newcode384
lily/constrained-breaking.cc:384: Line_details for anything.  That's
because the approximations
Is this still true?  It appears to be used in several places.

http://codereview.appspot.com/1670042/diff/1/3#newcode406
lily/constrained-breaking.cc:406: SCM page_breaking_spacing_spec =
l->c_variable ("page-breaking-between-system-spacing");
Is this here for future use or is it left over from your original
spacing patch?

http://codereview.appspot.com/1670042/show



reply via email to

[Prev in Thread] Current Thread [Next in Thread]