[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for issue #1116 (one stencil in fill-line) (issue1689041)
From: |
perpeduumimmobile |
Subject: |
Re: Patch for issue #1116 (one stencil in fill-line) (issue1689041) |
Date: |
Mon, 12 Jul 2010 16:14:02 +0000 |
Reviewers: joeneeman, Neil Puttock,
Message:
On 2010/06/30 18:34:35, joeneeman wrote:
Are you still waiting for someone to review this?
Sorry, missed the notifications - I don't usually check my gmail
account.
http://codereview.appspot.com/1689041/diff/2001/3001#newcode848
scm/define-markup-commands.scm:848: X RIGHT fill-space
line-stencils)))
These two set!s could be written more concisely as [..]
As Neil noted, it's for the if.
http://codereview.appspot.com/1689041/diff/2001/3001#newcode850
scm/define-markup-commands.scm:850: (if (> word-count 1)
I know there aren't many comments in the code, but that doesn't mean
you can't
add one...
Okay. :-) Better?
Description:
Patch for issue #1116 (one stencil in fill-line)
Avoid translation of stencils if only one markup is given as argument
for fill-line.
Regressions not checked yet.
Please review this at http://codereview.appspot.com/1689041/show
Affected files:
M scm/define-markup-commands.scm