Re: "patch" for underline function

[Graham Percival]

On Wed, Jul 14, 2010 at 12:08:39PM +0200, Alexander Kobel wrote:
> Kieren still lacks a git setup, though, and this very patch has only  
> been mentioned on the -devel list and the bug tracker, so I guess it's a  
> special case.

ah, ok.  I missed that.

> I can prepare a proper git patch and post it on Rietveld,  
> but I'd rather do so once I have some comments about the font-size  
> relation of this functionality.

ok, that would be great.

> Regarding your new entry in the tracker about how to comment:  Rietveld  
> looks like the best option for reviews, but I dislike to force everybody  
> to use it.  I'm not sure how many developers really can't prepare git  
> diffs or submit to Rietveld,

Everybody developer can do this.  Lilybuntu makes it easy to have
git and compile stuff.

I need to clarify the installation instructions and verify this
for myself, but once that's done, we will expect all contributors
to send properly-formatted git patches, work with rietveld, etc.

> but I vaguely remember and respect David's  
> concerns to open yet another account, especially with a possible data  
> leech, and it requires an up-and-running git.

I'm not happy about requiring a gmail account, but since that's
necessary for the issue tracker as well, I think we just need to
bite the bullet and accept it.  :(

> Since it requires write access to finally push the patch anyway, I  
> propose discussions on -devel, and a link to the thread in the bug  
> tracker for reference.

That's fine for this special case, and since the lilybuntu
instructions aren't crystal-clear yet.

Cheers,
- Graham