[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accord
From: |
dak |
Subject: |
Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041) |
Date: |
Thu, 29 Jul 2010 20:05:30 +0000 |
On 2010/07/29 19:29:39, Neil Puttock wrote:
http://codereview.appspot.com/1908041/diff/2001/3003
File python/convertrules.py (right):
http://codereview.appspot.com/1908041/diff/2001/3003#newcode3044
python/convertrules.py:3044: str = re.sub
(r'(\\musicglyph\s*#"accordion\.)([a-zA-Z]+)"',
Could be more generic, since it won't convert scheme markup:
(markup #:musicglyph "...")
or
(make-musicglyph-markup "...")
I don't think that convert-ly is supposed to deal with Scheme markup
conversion. Searching for #: in the convertrules turns up exactly
nothing.
http://codereview.appspot.com/1908041/show
- feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041), Carl . D . Sorensen, 2010/07/28
- Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041), dak, 2010/07/29
- Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041), dak, 2010/07/29
- Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041), percival . music . ca, 2010/07/29
- Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041), n . puttock, 2010/07/29
- Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041),
dak <=
- Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041), n . puttock, 2010/07/29