lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Part-combine: Add a way to override the part-combination decision by


From: Carl . D . Sorensen
Subject: Re: Part-combine: Add a way to override the part-combination decision by a ctx prop (issue1698054)
Date: Sun, 24 Oct 2010 10:38:23 +0000

LGTM

Carl


http://codereview.appspot.com/1698054/diff/17001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/1698054/diff/17001/ly/music-functions-init.ly#newcode602
ly/music-functions-init.ly:602: #(define (symbol-or-boolean? x) (or
(symbol? x) (boolean? x)))
add to scm/c++.scm, and add entry to scm/lily.scm

http://codereview.appspot.com/1698054/diff/17001/scm/part-combiner.scm
File scm/part-combiner.scm (right):

http://codereview.appspot.com/1698054/diff/17001/scm/part-combiner.scm#newcode548
scm/part-combiner.scm:548: (analyse-forced-combine 0 #f)
U.S. spelling --> analyze

But I see that the standard in this file is analyse, so I'm not sure
what the best way to proceed is.

http://codereview.appspot.com/1698054/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]