Re: Allow predefined diagrams regardless of note names language. (issue2791041)

[Valentin Villenave]

On Thu, Oct 28, 2010 at 3:11 PM,  <address@hidden> wrote:
> This looks good to me, but I haven't run make check on it yet.  It
> certainly shouldn't be pushed without make check being run.

You're quite right.

***testing...***

OK, make check doesn't complain, and there's no difference with the
baseline (only test-output-distance is changed, which is the expected
behavior).

> The technique of saving the language at the top of a file to be included
> and restoring it at the bottom should be documented, so people know to
> do it.  It would be nice if we could write a music function to do so,
> but that would delay the evaluation of the #(set! ), so I don't think we
> can.

Indeed. I tried to modify the storePredefinedDiagram macro instead,
but setting and unsetting pitchnames for every single diagram was
overkill in comparison.

I think this solution is the simplest and the most straightforward one.

Cheers,
Valentin.