[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Allow predefined diagrams regardless of note names language. (issue2
From: |
percival . music . ca |
Subject: |
Re: Allow predefined diagrams regardless of note names language. (issue2791041) |
Date: |
Fri, 29 Oct 2010 06:17:52 +0000 |
LGTM.
(for clarity: none of the comments made so far will force a second
draft, so if nobody has a complaint in the next 5 hours, you're good to
push it)
http://codereview.appspot.com/2791041/diff/1/ly/predefined-guitar-fretboards.ly
File ly/predefined-guitar-fretboards.ly (right):
http://codereview.appspot.com/2791041/diff/1/ly/predefined-guitar-fretboards.ly#newcode20
ly/predefined-guitar-fretboards.ly:20: #(set! pitchnames
default-language)
Cool! Is there any way to make this easy for normal users to use?
(then again, can we think of any case where a composer would want to be
switching input languages? not in normal circumstances, but would
anybody ever want to define some music to be used in a \include file ?
... hmm, that seems a bit far-fetched. ok, ignore this idea)
http://codereview.appspot.com/2791041/