[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Allow predefined diagrams regardless of note names language. (issue2
From: |
n . puttock |
Subject: |
Re: Allow predefined diagrams regardless of note names language. (issue2791041) |
Date: |
Fri, 29 Oct 2010 08:54:54 +0000 |
http://codereview.appspot.com/2791041/diff/1/ly/predefined-guitar-fretboards.ly
File ly/predefined-guitar-fretboards.ly (right):
http://codereview.appspot.com/2791041/diff/1/ly/predefined-guitar-fretboards.ly#newcode20
ly/predefined-guitar-fretboards.ly:20: #(set! pitchnames
default-language)
On 2010/10/29 08:11:00, Valentin Villenave wrote:
(BTW: In these fretboard files, I'm not actually using \language since
I
don't need to change the parser's note names, but merely the
pitchnames
definition that's used by chordmode.)
I think you should add a comment to this effect for these files, just in
case somebody looks at them and wonders why.
http://codereview.appspot.com/2791041/