Re: T1249 - Remove (define define-ly-syntax define-public). (issue2313044)

[ianhulin44]

Comments actioned and tested with LilyPond using Guile V1.8.7 and
V1.9.13.

Ian


http://codereview.appspot.com/2313044/diff/1/scm/ly-syntax-constructors.scm
File scm/ly-syntax-constructors.scm (left):

http://codereview.appspot.com/2313044/diff/1/scm/ly-syntax-constructors.scm#oldcode20
scm/ly-syntax-constructors.scm:20: (define define-ly-syntax
define-public)
On 2010/10/08 05:00:01, Patrick McCarty wrote:
> Instead of removing this definition (like I did), would it be possible
to use a
> macro here?  Something like

>    (defmacro define-ly-syntax (args . body)
>      `(define-public ,args ,body))

> This is untested.
Tests out OK with V1.9 and V1.8.7
Done.

http://codereview.appspot.com/2313044/diff/1/scm/ly-syntax-constructors.scm
File scm/ly-syntax-constructors.scm (right):

http://codereview.appspot.com/2313044/diff/1/scm/ly-syntax-constructors.scm#newcode27
scm/ly-syntax-constructors.scm:27: `(define-public ,args
On 2010/10/08 05:00:01, Patrick McCarty wrote:
> I forgot why I changed this...

> Is there a reason why "primitive-eval" was used here in the first
place?
Both Guile V1.8.7 and V1.9 work without it.  I assume it was cruft left
over from Guile V1.6 compatibility.
Ian

http://codereview.appspot.com/2313044/diff/1/scm/ly-syntax-constructors.scm#newcode250
scm/ly-syntax-constructors.scm:250: (define-public (partial parser
location dur)
On 2010/10/08 05:00:01, Patrick McCarty wrote:
> This part needs to be rebased against current master.
Sorted out in new patch-set
Done.

http://codereview.appspot.com/2313044/