[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Add support for tempo ranges (issue3248042)
From: |
n . puttock |
Subject: |
Re: [Patch] Add support for tempo ranges (issue3248042) |
Date: |
Wed, 24 Nov 2010 00:28:37 +0000 |
Hi Valentin,
This generally looks fine (even if it runs a cart and horses through my
patch for issue 1205. ;)
The only thing I'm concerned about is the hybrid type; it's poorly
named: `number-or-pair?' doesn't suggest a number-pair, but
`number-or-number-pair?' is even worse.
I think using a list might a price worth paying to avoid creating a new
predicate.
Cheers,
Neil
http://codereview.appspot.com/3248042/diff/6001/input/regression/metronome-range.ly
File input/regression/metronome-range.ly (right):
http://codereview.appspot.com/3248042/diff/6001/input/regression/metronome-range.ly#newcode11
input/regression/metronome-range.ly:11: \tempo 4 = 66~72
66 ~ 72
http://codereview.appspot.com/3248042/
- [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), Carl . D . Sorensen, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), reinhold . kainhofer, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042),
n . puttock <=
- Re: [Patch] Add support for tempo ranges (issue3248042), Carl . D . Sorensen, 2010/11/23
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/24
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), Carl . D . Sorensen, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/26