[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Add support for tempo ranges (issue3248042)
From: |
v . villenave |
Subject: |
Re: [Patch] Add support for tempo ranges (issue3248042) |
Date: |
Sat, 27 Nov 2010 00:05:00 +0000 |
On 2010/11/26 23:51:27, Neil Puttock wrote:
Great, but don't forget to do the same for this,
\tempo "foo" 60 ~ 63
Indeed.
and tests the display methods in display-lily-tests.ly (we're
currently missing
tests for the newer \tempo commands anyway; you might as well add them
too,
e.g., http://codereview.appspot.com/2145047/patch/1/2)
Good idea. I had totally forgotten about this regtest.
Once that's sorted, it should be ready to go. Then I can set about
undoing some
of your work when I rebase my patch. ;)
I haven't really had a look at your patch so far, but it does look
really interesting! Look, it's really up to you whether I should push my
patch first or the other way around, I really don't mind rebasing my own
patch onto your work (if anything, this will be a good exercise).
Cheers,
Valentin.
http://codereview.appspot.com/3248042/
- Re: [Patch] Add support for tempo ranges (issue3248042), (continued)
- Re: [Patch] Add support for tempo ranges (issue3248042), Carl . D . Sorensen, 2010/11/23
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/24
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), Carl . D . Sorensen, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/26
- Re: [Patch] Add support for tempo ranges (issue3248042),
v . villenave <=
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/26
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/30