Re: Doc: CG: clarify lily-git.tcl and git-cl. (issue3396042)

[percival . music . ca]

On 2010/12/06 23:12:09, Valentin Villenave wrote:
> Hi Graham,
> LGTM as well. Just a few comments:

Thanks, pushed.

> Documentation/contributor/source-code.itexi:143: @quotation
> Is there a rule for the use of @quotation? (I noticed there's another
one in
> source-code.itexi.) If so, we probably should add it to the CG's
Syntax Survey.

No, but I don't think we need to mention it.  The CG is a special case;
the usual docs shouldn't use quotation.

> I wouldn't bother with the size limit, it's much less drastic on
address@hidden What I
> *would* mention, however, is to add [PATCH] in the email's subject.

Thanks, done.

> Documentation/contributor/source-code.itexi:1032: You must have a
gmail account.
> Are all Google accounts Gmail accounts? (I don't suppose it's owrth
adding a
> @uref{https://www.google.com/accounts/NewAccount} link, is it?)

I don't know; I just left that part of the docs alone.  Once the current
discussion about virtualization dies down, I'll ask somebody to look
into gmail vs. google accounts.


http://codereview.appspot.com/3396042/diff/1/Documentation/contributor/source-code.itexi#newcode1051
> Documentation/contributor/source-code.itexi:1051: answer with a
newline (CR).
> How about "just hit Return"?

I think that "newline (CR)" is a bit more technical, so I left it as-is.
 I'm not particularly fussy about this, though.


http://codereview.appspot.com/3396042/