Re: Rewrite NR 3.2 Titles and headers. (issue3667041)

[pkx166h]

Hope these aren't too nit-picky.


http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode527
Documentation/notation/input.itely:527:
Could we have some appropriate @cindex here? and possibly some
@funindex? I think this would be really useful

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode547
Documentation/notation/input.itely:547: @code{\score} blocks).  It is
typically placed near the top of the
Can't you just say simply that

...text fields for the main title block should be placed outside of and
before a \score block.

(what is 'toplevel scope'?).

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode558
Documentation/notation/input.itely:558: block.  On the other hand, the
@code{piece} text fields belong to
'However' instead of 'On the other hand' (too idiomatic).

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode570
Documentation/notation/input.itely:570: \clef bass \key g \major
new line for \key g \major

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode581
Documentation/notation/input.itely:581: \clef bass \key g \major
new line for \key g \major

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode593
Documentation/notation/input.itely:593: can be displayed in individual
score title blocks by adding the
does 'score' in this sentence need @code{\score}?

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode601
Documentation/notation/input.itely:601: @code{\header} blocks, so some
fields may need to manually
some fields may need to *be* manually...

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode603
Documentation/notation/input.itely:603: @code{##f}).
I think the brackets here are unnecessary and would prefer to see
'print-all-headers = ##f' in full.

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode611
Documentation/notation/input.itely:611:
@lilypond[quote,verbatim,noragged-right,staffsize=17]
Some of these aren't standard @lilypond variables and we do ask that any
changes in Doc to these are 'discussed' :)

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode657
Documentation/notation/input.itely:657:
Need @seealso for
 @ref{Custom layout for title blocks}

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode743
Documentation/notation/input.itely:743:
Need @seealso for

@file{ly/titling-init.ly}
@ref{Custom layout for title blocks}

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode772
Documentation/notation/input.itely:772: right (if odd), starting on the
second page.
Starting on the second page, even page numbers are placed on the left
and odd on the right.

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode808
Documentation/notation/input.itely:808:
Need @seealso

@file{ly/titling-init.ly}

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode829
Documentation/notation/input.itely:829:
@lilypond[quote,verbatim,noragged-right,indent=15\mm,staffsize=17]
Ditto above for @lilypond variables - not standard

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode875
Documentation/notation/input.itely:875:
@lilypond[quote,verbatim,noragged-right,indent=15\mm,staffsize=17]
Ditto above regarding non Standard @lilypond variables.

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode889
Documentation/notation/input.itely:889:
@lilypond[quote,verbatim,noragged-right,staffsize=17]
Ditto above regarding non Standard @lilypond variables.

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode931
Documentation/notation/input.itely:931:
@lilypond[quote,verbatim,noragged-right,staffsize=17]
Ditto above regarding non Standard @lilypond variables.

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode1062
Documentation/notation/input.itely:1062:
We need  @seealso here

Notation Reference
@ref{Title blocks explained}
@ref{Default layout of book and score title blocks}

One for Internals too
{ly/titling-init.ly}

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode1071
Documentation/notation/input.itely:1071: as for title blocks (see
is it 'basically the same' or just 'the same' if you see what I mean?

http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode1114
Documentation/notation/input.itely:1114: @end lilypond
Another @seealso needed
@ref{Custom layout for title blocks}
@ref{Default layout of headers and footers}

http://codereview.appspot.com/3667041/