Re: [Patch] make post-event music functions direction-aware (issue3743043)

[n . puttock]

On 2010/12/21 22:56:05, Valentin Villenave wrote:

> Oh, I didn't know 0 was false, in Guile you can have something like:

> guile> (define a 0)
> guile> (if a (display "true\n"))
> true
> guile>

Yep, Scheme is strict about #f: it's not equal to any other object.

> Do you think I can push this patch now? (Not sure where to document
it, though.
> Probably somewhere in the Extending manual.)

I don't think you need to copy the function evaluation result into a new
SCM object, but apart from that it LGTM.

Cheers,
Neil

http://codereview.appspot.com/3743043/