Re: Clef support for cue notes (issue2726043)

[n . puttock]

Hi Reinhold,

You're missing definitions for explicitCueClefVisibility and
quoted-music-clef.

Cheers,
Neil


http://codereview.appspot.com/2726043/diff/21001/Documentation/changes.tely
File Documentation/changes.tely (right):

http://codereview.appspot.com/2726043/diff/21001/Documentation/changes.tely#newcode71
Documentation/changes.tely:71: clef, which is correctly reset at the end
of the cue notes. At the begin
notes.  At

http://codereview.appspot.com/2726043/diff/21001/Documentation/changes.tely#newcode79
Documentation/changes.tely:79: \clef "bass"
indent

http://codereview.appspot.com/2726043/diff/21001/Documentation/changes.tely#newcode81
Documentation/changes.tely:81: c4 \cueDuringWithClef #"vIQuote" #DOWN
#"treble" { r4 r2 |
{
  r4 r2 |

http://codereview.appspot.com/2726043/diff/21001/Documentation/changes.tely#newcode82
Documentation/changes.tely:82: r4 } c4 c2 |
  r4
}

http://codereview.appspot.com/2726043/diff/21001/Documentation/changes.tely#newcode83
Documentation/changes.tely:83: \cueDuringWithClef #"vIQuote" #DOWN
"soprano" {R1*2 \break R1 } |
{ R1*2

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-begin-of-score.ly
File input/regression/cue-clef-begin-of-score.ly (right):

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-begin-of-score.ly#newcode1
input/regression/cue-clef-begin-of-score.ly:1: \version "2.13.41"
2.13.45

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-begin-of-score.ly#newcode4
input/regression/cue-clef-begin-of-score.ly:4: texidoc = "Clefs for cue
notes at the start of a score should print the
indent

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-begin-of-score.ly#newcode12
input/regression/cue-clef-begin-of-score.ly:12: \clef "bass"
indent

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-new-line.ly
File input/regression/cue-clef-new-line.ly (right):

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-new-line.ly#newcode1
input/regression/cue-clef-new-line.ly:1: \version "2.13.41"
2.13.45

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-new-line.ly#newcode4
input/regression/cue-clef-new-line.ly:4: texidoc = "Clefs for cue notes
and line breaks. If the cue notes start in a
breaks.  If

indent

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-new-line.ly#newcode5
input/regression/cue-clef-new-line.ly:5: new line, the cue clef should
not be printed at the end of the previuos line.
previous

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-new-line.ly#newcode9
input/regression/cue-clef-new-line.ly:9: Cue notes going over a line
break should print the standard clef in the new
on the new

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-new-line.ly#newcode17
input/regression/cue-clef-new-line.ly:17: \clef "bass"
indent

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-octavation.ly
File input/regression/cue-clef-octavation.ly (right):

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-octavation.ly#newcode1
input/regression/cue-clef-octavation.ly:1: \version "2.13.41"
2.13.45

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-octavation.ly#newcode4
input/regression/cue-clef-octavation.ly:4: texidoc = "Octavation for
clefs for cue notes."
indent

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-octavation.ly#newcode11
input/regression/cue-clef-octavation.ly:11: \clef "treble_8" c1 |
indent

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-octavation.ly#newcode13
input/regression/cue-clef-octavation.ly:13: c1 |\break
| \break

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef-octavation.ly#newcode18
input/regression/cue-clef-octavation.ly:18: \cueDuringWithClef
#"vIQuote" #UP #"treble_8" { R1 \break R} |
R }

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef.ly
File input/regression/cue-clef.ly (right):

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef.ly#newcode1
input/regression/cue-clef.ly:1: \version "2.13.41"
2.13.45

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef.ly#newcode3
input/regression/cue-clef.ly:3: % FIXME: Split this up into several
different test cases
remove

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef.ly#newcode5
input/regression/cue-clef.ly:5: texidoc = "Clefs for cue notes: Print a
cue clef at the begin of the cue
indent

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef.ly#newcode13
input/regression/cue-clef.ly:13: \clef "bass"
indent

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef.ly#newcode14
input/regression/cue-clef.ly:14: c4 \cueDuringWithClef #"vIQuote" #DOWN
#"treble" { r4 r2 |
formatting { }

http://codereview.appspot.com/2726043/diff/21001/input/regression/cue-clef.ly#newcode16
input/regression/cue-clef.ly:16: \cueDuringWithClef #"vIQuote" #DOWN
"soprano" {R1*2 } |
{ R1*2

http://codereview.appspot.com/2726043/diff/21001/lily/cue-clef-engraver.cc
File lily/cue-clef-engraver.cc (right):

http://codereview.appspot.com/2726043/diff/21001/lily/cue-clef-engraver.cc#newcode235
lily/cue-clef-engraver.cc:235: "cueClefPosition "
+ explicitCueClefVisibility

http://codereview.appspot.com/2726043/diff/21001/scm/music-functions.scm
File scm/music-functions.scm (right):

http://codereview.appspot.com/2726043/diff/21001/scm/music-functions.scm#newcode802
scm/music-functions.scm:802: (make-music 'Music)
indent

http://codereview.appspot.com/2726043/diff/21001/scm/music-functions.scm#newcode806
scm/music-functions.scm:806: (context-spec-music
(make-voice-props-revert)  'CueVoice "cue")
) 'CueVoice

http://codereview.appspot.com/2726043/diff/21001/scm/music-functions.scm#newcode808
scm/music-functions.scm:808: (make-music 'Music)
indent

http://codereview.appspot.com/2726043/