Re: Fix Issue 1290 (issue3832046)

[k-ohara5a5a]

It is interesting to see what gets horizontally padded and what does not
-- accidentals do not, for example.
Whether by accident or design, the choices on what to pad seem
reasonable.

It seems that the same padded skyline is used both for page layout, and
for drawing the outer skylines with debug-skylines.  However, I could
not follow the code to see if the same function is called.  I would
worry about confusion in the future if System's skyline is padded two
different places in the code.


http://codereview.appspot.com/3832046/diff/2001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):

http://codereview.appspot.com/3832046/diff/2001/lily/page-layout-problem.cc#newcode204
lily/page-layout-problem.cc:204: Real minimum_distance =
up_skyline.distance (bottom_skyline_) + padding;
On 2011/01/02 23:09:02, Keith wrote:
If I call using Carl's new function here,

  Real minimum_distance = up_skyline.distance (bottom_skyline_,
    robust_scm2double (sys->get_property ("skyline-horizontal-padding"),
0)) + padding;

I like the behavior much than the way 2.12.3 worked.  Old 2.12's
horizontal padding would push rehearsal marks and bar numbers away from
notes on their home staff.

http://codereview.appspot.com/3832046/